[Console] Fix: Allow to inject QuestionHelper into SymfonyStyle #17468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/cc @zcuric |
localheinz
force-pushed
the
fix/symfony-style-question
branch
from
ec20df3 to
3bd4b06
Compare
Contributor
Author
|
Build failures seem unrelated to the changes in this PR. |
Member
|
it looks to not break BC, could this go to 2.x line ? |
Member
|
looks like a duplicate of #17136 |
Contributor
Author
|
Ha, right - except:
|
Member
|
@localheinz I don't care which one we finish. :) |
Contributor
Author
|
Closing in favour of #17136. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Helper\QuestionHelpercan be injected intoStyle\SymfonyStyleHelper\QuestionHelperotherwise internally created byStyle\SymfonyStyle💁 If using
Style\SymfonyStyleand asking a question in a command, it's impossible to use the instructions laid out here to provide an input stream. By allowing to inject an instance ofHelper\QuestionHelperintoStyle\SymfonyStyle, testing becomes possible again.