[Serializer] Ensure that groups are strings #17430
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dunglas
commented
Jan 18, 2016
dunglas
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
Contributor
|
👍 One more thing to note. If such a yml is provided to the loader: Acme\MyObj:
attributes:
foo:
groups: 'group1'
If you think this should be in another PR, than sorry. :) |
dunglas
force-pushed
the
sr_yaml_groups
branch
from
3b6a90b to
b8a9e7c
Compare
Member
Author
|
Good catch @paradajozsef, I've added a separate commit in this PR. |
Contributor
|
👍 |
Contributor
|
This is more a bug fix than a new feature ;-) 👍 debugging is easier with this kind of check 😄 |
Member
|
We should include the name of the file and probably some other related information (class name, property or something like that) to make it easier to spot the place where the configuration is wrong. |
Member
|
I agree with @xabbuh |
Member
Author
Member
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Jan 26, 2016
This PR was squashed before being merged into the 2.7 branch (closes #17430). Discussion ---------- [Serializer] Ensure that groups are strings | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 0a3b877 [Serializer] Ensure that groups are strings
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.