Skip to content

[Validator] Fix wrong php docs #17092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GuilhemN wants to merge 1 commit into from
Closed

[Validator] Fix wrong php docs #17092

GuilhemN wants to merge 1 commit into from

Conversation

@GuilhemN
Copy link
Contributor

@GuilhemN GuilhemN commented Dec 21, 2015

Q A
Fixed tickets #17091
License MIT

@GuilhemN GuilhemN changed the title [Validator] fixed wrong php docs [Validator] Fix wrong php docs Dec 21, 2015
xabbuh
xabbuh reviewed Dec 22, 2015
View reviewed changes
src/Symfony/Component/Validator/Validation.php Outdated
Copy link
Member

@xabbuh xabbuh Dec 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a use statement for the interface instead

Copy link
Contributor Author

@GuilhemN GuilhemN Dec 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@xabbuh
Copy link
Member

xabbuh commented Dec 22, 2015

should be merged into 3.0

@GuilhemN
Copy link
Contributor Author

GuilhemN commented Dec 22, 2015

I rebased my PR on 3.0 is it enough ?

@Tobion
Copy link
Contributor

Tobion commented Dec 22, 2015

Thanks @Ener-Getick.

Tobion added a commit that referenced this pull request Dec 22, 2015
@Tobion
minor #17092 [Validator] Fix wrong php docs (Ener-Getick)
a798d7d 
This PR was submitted for the master branch but it was merged into the 3.0 branch instead (closes #17092).

Discussion
----------

[Validator] Fix wrong php docs

| Q             | A
| ------------- | ---
| Fixed tickets | #17091
| License       | MIT

Commits
-------

9911524 [Validator] fixed wrong php docs
@Tobion Tobion closed this Dec 22, 2015
@GuilhemN GuilhemN deleted the VALIDATORPHPDOC branch December 22, 2015 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Status: Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuilhemN @xabbuh @Tobion @carsonbot