[Form] fix #15544 when a collection type attribute "required" is false, "prototype" should too #16959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeahDude
commented
Dec 11, 2015
HeahDude
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15544 |
| License | MIT |
| Doc PR | - |
Contributor
|
Thanks, this PR is a good fix 👍 |
Member
|
👍 LGTM @webmozart Can you please have a look here too? :) |
Member
|
👍 |
Member
|
Thank you @HeahDude. |
fabpot
added a commit
that referenced
this pull request
Dec 18, 2015
…ed" is false, "prototype" should too (HeahDude) This PR was squashed before being merged into the 2.3 branch (closes #16959). Discussion ---------- [Form] fix #15544 when a collection type attribute "required" is false, "prototype" should too | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15544 | License | MIT | Doc PR | - Commits ------- b4b5d63 [Form] fix #15544 when a collection type attribute "required" is false, "prototype" should too
This was referenced Dec 26, 2015
Merged
Merged
Merged
Merged
Tobion
added a commit
that referenced
this pull request
Apr 6, 2016
This PR was merged into the 2.3 branch. Discussion ---------- [Form] Remove unnecessary option assignment | Q | A | ------------- | --- | Branch? | 2.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Option assignment is not required because the prototype inherits this option from the parent form via standard inheritance mechanism. Related pull requests: #16959, #18317 Commits ------- da8a197 Remove unnecessary option assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.