[FrameworkBundle] PropertyInfo: register the SerializerExtractor #16947
Conversation
dunglas
commented
Dec 10, 2015
dunglas
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
dunglas
changed the title
|
ping @symfony/deciders |
|
👍 |
|
Switched from Prophecy to the PHPUnit old mock system. Travis errors look unrelated. |
|
ping @stof |
There was a problem hiding this comment.
Why don't we configure this in the serializer.xml file of the FrameworkBundle where the serializer.mapping.class_metadata_factory service is registered?
There was a problem hiding this comment.
Because this service should not be added if serializer.mapping.class_metadata_factory doesn't exist.
There was a problem hiding this comment.
I understand, but when we configure it in serializer.xml it will only be registered when serializer.mapping.class_metadata_factory would be registered too.
dunglas
force-pushed
the
fwbundle_propinf_srlzrextrctr
branch
from
8b17199 to
ac529c7
Compare
dunglas
force-pushed
the
fwbundle_propinf_srlzrextrctr
branch
from
b7e564a to
3a936dd
Compare
|
👍 |
|
How do we deal with dependencies now? The Serializer configuration would now require to have the PropertyInfo component in 3.1 or higher. Should we remove the service when an older version of the component is present? |
8 participants
