Allows access to payload in callback validator #16909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
conradkleinespel
commented
Dec 8, 2015
conradkleinespel
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15092 |
| License | MIT |
| Doc PR | none |
Member
There was a problem hiding this comment.
Imo this should be changed to something like testPayloadIsPasswordToCallback to reflect what we actually expect to happen in the test.
Contributor
There was a problem hiding this comment.
@xabbuh you probably meant testPayloadIsPassedToCallback() ;)
Contributor
Author
There was a problem hiding this comment.
Done. Thanks for the suggestion 👍
Member
|
Thank you @conradkleinespel. |
fabpot
added a commit
that referenced
this pull request
Jan 25, 2016
…kleinespel) This PR was merged into the 3.1-dev branch. Discussion ---------- Allows access to payload in callback validator | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15092 | License | MIT | Doc PR | none Commits ------- 26cd91d allows access to payload in callback validator
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.