Skip to content

[hackday] deprecate voteOnAttribute #16853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brpauwels wants to merge 2 commits into from
Closed

[hackday] deprecate voteOnAttribute #16853

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
462a157
deprecate voteOnAttribute
brpauwels Dec 5, 2015
688f61d
fix cs
brpauwels Dec 5, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/Symfony/Component/Security/Core/Authorization/Voter/Voter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,22 @@ public function vote(TokenInterface $token, $subject, array $attributes)
*/
abstract protected function supports($attribute, $subject);

/**
* Perform a single access check operation on a given attribute, subject and token.
*
* @param string $attribute
* @param mixed $subject
* @param TokenInterface $token
*
* @return bool
*
* @deprecated
*/
protected function voteOnAttribute($attribute, $subject, TokenInterface $token)
{
return $this->shouldHaveAccess($attribute, $subject, $token);
}

/**
* Perform a single access check operation on a given attribute, subject and token.
*
Expand All @@ -65,5 +81,5 @@ abstract protected function supports($attribute, $subject);
*
* @return bool
*/
abstract protected function voteOnAttribute($attribute, $subject, TokenInterface $token);
abstract protected function shouldHaveAccess($attribute, $subject, TokenInterface $token);
}