Skip to content

Conversation

@belka-ew
Copy link
Contributor

Remove deprecated $deep filter parameter.
Related to #16629

Remove deprecated $deep filter parameter.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add @trigger_error('The "deep" argument of '.__METHOD__.' is deprecated since version 2.8 and will be removed in 3.0.', E_USER_DEPRECATED); in this condition.

@Tobion
Copy link
Contributor

Tobion commented Nov 27, 2015

Please also update the tests for filter: https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/HttpFoundation/Tests/ParameterBagTest.php#L162

  • copy testFilter to testLegacyFilter with a @group legacy annotation (see other tests)
  • in testFilter remove the deprecated deep argument so it doesnt trigger a deprecation

@nicolas-grekas
Copy link
Member

Replaced by #16706, thank you @belka-ew

@belka-ew belka-ew deleted the remove_filter_deep_argument branch November 27, 2015 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants