Skip to content

Conversation

@webmozart
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@webmozart
Copy link
Contributor Author

This PR replaces various class name strings by the ::class constants. The remaining occurrences of such strings can be replaced in other PRs.

@nicolas-grekas
Copy link
Member

we refused such changes because it complicates merges from 2.8 to master for no practical benefit...

@nicolas-grekas
Copy link
Member

See #16648 that has just been closed

@webmozart
Copy link
Contributor Author

Ah ok.

@webmozart webmozart closed this Nov 25, 2015
@webmozart webmozart deleted the class_const branch November 25, 2015 15:52
@Tobion
Copy link
Contributor

Tobion commented Nov 25, 2015

I thought about adding a NAME constant to all form types in 2.3 that have the shorthand name in 2.3-2.7 and the FQCN in 2.8. In 3.0 we can then just change the constant to const NAME = self::class;.

Then we could use the NAME constant in all code and documentation and in all branches. I guess that would be easier to maintain and more readable.
But it also involves alot of merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants