[Console] Fix bug in windows detection #16578
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kbond
commented
Nov 17, 2015
kbond
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #16577 |
| License | MIT |
| Doc PR | n/a |
kbond
changed the title
Member
|
👍 |
Member
|
👍 Status: Reviewed |
Contributor
|
Just a curious. What is a standard way to check OS in Symfony? At some places it is check DIRECTORY_SEPARATOR, in another places it is strpos(PHP_OS, "WIN") === 0. |
Member
|
@ewgRa We always check the value of the |
Member
|
Thank you @kbond. |
fabpot
added a commit
that referenced
this pull request
Nov 18, 2015
This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #16578). Discussion ---------- [Console] Fix bug in windows detection | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16577 | License | MIT | Doc PR | n/a Commits ------- c4068d9 Fix bug in windows detection
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.