Skip to content

Re-adding the ability to add a resource to the RouteCollectionBuilder #16404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jasonjyu wants to merge 1 commit into from
Closed

Re-adding the ability to add a resource to the RouteCollectionBuilder #16404

jasonjyu wants to merge 1 commit into from
+24 −0

Conversation

@jasonjyu
Copy link

@jasonjyu jasonjyu commented Oct 31, 2015

We need this because when you import a RouteCollection and this has a resource
on it, we need to pass that resource forward to the RouteCollectionBuilder

@weaverryan
Re-adding the ability to add a resource to the RouteCollectionBuilder
549a3e2 
We need this because when you import a RouteCollection and this has a resource
on it, we need to pass that resource forward to the RouteCollectionBuilder
@xabbuh
Copy link
Member

xabbuh commented Oct 31, 2015

Thanks for creating this pull request @jasonjyu. However, @weaverryan already opened one to add this feature again (see #16361). So I'm closing here.

@xabbuh xabbuh closed this Oct 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Status: Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jasonjyu @xabbuh @carsonbot @weaverryan