Skip to content

[HttpKernel] clearstatcache() so the Cache sees when a .lck file has been released #16312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mpdude wants to merge 4 commits into from
Closed

[HttpKernel] clearstatcache() so the Cache sees when a .lck file has been released #16312

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d374e04
Add clearstatcache() call before checking cache lock
mpdude Oct 22, 2015
d4e92d1
FabBot
mpdude Oct 22, 2015
e4276e7
FabBot, again
mpdude Oct 22, 2015
7930b75
Assumed wrong clearstatcache() signature
mpdude Oct 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Symfony/Component/HttpKernel/HttpCache/Store.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,10 @@ public function unlock(Request $request)

public function isLocked(Request $request)
{
return is_file($this->getPath($this->getCacheKey($request).'.lck'));
$path = $this->getPath($this->getCacheKey($request).'.lck');
clearstatcache(true, $path);

return is_file($path);
Copy link
Member

@xabbuh xabbuh Nov 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the file check absolutely necessary or couldn't we just call file_exists() which doesn't use the stat cache?

Copy link
Contributor

@MatTheCat MatTheCat Nov 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation of clearstatcache says file_exists is affected.

Copy link
Contributor

@jakzal jakzal Nov 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatTheCat is right here, only the information about non-existent files is not cached:

You should also note that PHP doesn't cache information about non-existent files. So, if you call file_exists() on a file that doesn't exist, it will return FALSE until you create the file. If you create the file, it will return TRUE even if you then delete the file. However unlink() clears the cache automatically.

Copy link
Member

@xabbuh xabbuh Nov 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think I confused that.

}

/**
Expand Down