Updated the style of the event commands #15999
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
javiereguiluz
commented
Sep 29, 2015
javiereguiluz
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
60 tasks
Contributor
There was a problem hiding this comment.
Why capitalizing those words (same below) ?
Member
Author
There was a problem hiding this comment.
because the style guide says that titles should use the "title-case", which is what we use in the Symfony docs, symfony.com, etc.
javiereguiluz
force-pushed
the
update_event_command
branch
from
7c0cecb to
8d7b686
Compare
Member
|
Looks like this one is breaking the tests. @javiereguiluz Can you have a look? |
javiereguiluz
force-pushed
the
update_event_command
branch
from
a952fe2 to
5606b38
Compare
Member
Author
|
Fixed tests (at least locally) |
Member
|
Thank you @javiereguiluz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.