Skip to content

Support "!!binary" syntax (decodes base64 string). #15958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot wants to merge 1 commit into from
Closed

Support "!!binary" syntax (decodes base64 string). #15958

fabpot wants to merge 1 commit into from

Conversation

@fabpot
Copy link
Member

@fabpot fabpot commented Sep 28, 2015

This PR was submitted on the symfony/yaml read-only repository by @johnnytemp and moved automatically to the main Symfony repository (closes symfony/yaml#13).

Only supported in folded-scalar (lines ending with | or >) form, or inline form.

Example Yaml:
items

name_enc: !!binary "SGVsbG8sIHdvcmxkLg=="
desc_enc: !!binary |
    SGVsbG8sIH
    dvcmxkLg==

@fabpot
Support "!!binary" syntax (decodes base64 string).
3d26c92 
Only supported in folded-scalar (lines ending with | or >) form, or inline form.
stof
stof reviewed Sep 28, 2015
View reviewed changes
src/Symfony/Component/Yaml/Parser.php
Copy link
Member

@stof stof Sep 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing curly braces

@stof
Copy link
Member

stof commented Sep 28, 2015

Tests covering this case are missing.

Status: needs work

@xabbuh xabbuh added the Yaml label Sep 28, 2015
@xabbuh xabbuh mentioned this pull request Oct 5, 2015
Closed
@fabpot
Copy link
Member Author

fabpot commented Jan 25, 2016

@johnnytemp Can you finish this one?

@johnnytemp
Copy link

johnnytemp commented Jan 28, 2016

@fabpot I am not familiar with the project. Tried, and find it hard to master the test tools. So, sorry, I won't do it currently.

@xabbuh
Copy link
Member

xabbuh commented Jan 28, 2016

@johnnytemp Thanks for the feedback. I'll finish this for you then.

@johnnytemp
Copy link

johnnytemp commented Jan 29, 2016

@xabbuh I have successfully triggered unit test and added unit test. I issued another pull request for this as #17599 to replace this. Thank you.

@fabpot
Copy link
Member Author

fabpot commented Jan 29, 2016

Closing in favor of #17599

@fabpot fabpot closed this Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Status: Needs Work Yaml

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fabpot @stof @johnnytemp @xabbuh @carsonbot