Skip to content

Conversation

@nicolas-grekas
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Patch on Security is required for tests compat with 3.0, see #15684
IntrospectableContainerInterface is already deprecated in master.

@nicolas-grekas nicolas-grekas changed the title [2.8] Cleanup [2.8] Deprecate IntrospectableContainerInterface Sep 4, 2015
@Tobion
Copy link
Contributor

Tobion commented Sep 4, 2015

ref #15346 (comment)

@nicolas-grekas
Copy link
Member Author

Thanks for the link.
Code wanting to be both 3.0 and 2.x compatible could rely on ContainerInterface + method_exists
Can we consider this?

@Tobion
Copy link
Contributor

Tobion commented Sep 4, 2015

I agree

@nicolas-grekas
Copy link
Member Author

I added 3.0 compat in Symfony\Bridge\ProxyManager\LazyProxy\PhpDumper\ProxyDumper

@Tobion
Copy link
Contributor

Tobion commented Sep 5, 2015

👍

@Tobion
Copy link
Contributor

Tobion commented Sep 5, 2015

Status: Reviewed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two constraints are duplicates of similar ones in framework-bundle, and for some reason (a bug in composer?) they can create dependency resolving failure. Removing them fixes the issue without changing anything to the resolved set.

@fabpot
Copy link
Member

fabpot commented Sep 6, 2015

Thank you @nicolas-grekas.

@fabpot fabpot merged commit c2b94a1 into symfony:2.8 Sep 6, 2015
fabpot added a commit that referenced this pull request Sep 6, 2015
…s-grekas)

This PR was merged into the 2.8 branch.

Discussion
----------

[2.8] Deprecate IntrospectableContainerInterface

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Patch on Security is required for tests compat with 3.0, see #15684
IntrospectableContainerInterface is already deprecated in master.

Commits
-------

c2b94a1 [2.8] Cleanup
@nicolas-grekas nicolas-grekas deleted the clean28 branch September 6, 2015 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants