Skip to content

Conversation

@zerustech
Copy link
Contributor

Added the test script as per the discussion in PR #15562

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@zerustech
Copy link
Contributor Author

ping @stof @aitboudad

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should typehint the argument

@stof
Copy link
Member

stof commented Sep 3, 2015

The new test you are adding is broken

Added the test script as per the discussion in PR symfony#15562

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a
@zerustech zerustech force-pushed the translation-update-command-test branch from ffac9cc to 232f6fd Compare September 3, 2015 09:06
@zerustech
Copy link
Contributor Author

@stof Fixed.

@fabpot
Copy link
Member

fabpot commented Sep 14, 2015

Thank you @zerustech.

@fabpot fabpot merged commit 232f6fd into symfony:2.3 Sep 14, 2015
fabpot added a commit that referenced this pull request Sep 14, 2015
… (zerustech)

This PR was merged into the 2.3 branch.

Discussion
----------

[framework-bundle] Add Test for TranslationUpdateCommand

Added the test script as per the discussion in PR #15562

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

232f6fd [framework-bundle] Add Test for TranslationUpdateCommand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants