[Form] only use PropertyPath if not already callable #15561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ping @symfony/deciders |
Member
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Aug 22, 2015
This PR was merged into the 2.7 branch. Discussion ---------- [Form] only use PropertyPath if not already callable | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | could be in edge cases | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15542 | License | MIT | Doc PR | - Currently it uses a PropertyPath even when the string is already a callable. But the callable string should have higher priority since that is also the one documented in ChoiceListFactoryInterface. Commits ------- 470b140 [Form] only use PropertyPath if not already callable
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it uses a PropertyPath even when the string is already a callable. But the callable string should have higher priority since that is also the one documented in ChoiceListFactoryInterface.