[SecurityBundle] Remove deprecated code #15430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dosten
commented
Aug 2, 2015
dosten
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| License | MIT |
Member
There was a problem hiding this comment.
This formatting change altering the indentation should be avoided, to make it easier to merge branches together (otherwise we would have to resolve conflicts all the time during the 2.x lifetime when changes are done on this code and propagated to 3.x)
Contributor
Author
|
@stof sorry, my bad. fixed. |
Member
|
👍 |
Contributor
Author
|
Great! Status: Reviewed |
Member
|
Thank you @dosten. |
fabpot
added a commit
that referenced
this pull request
Aug 5, 2015
This PR was merged into the 3.0-dev branch. Discussion ---------- [SecurityBundle] Remove deprecated code | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | License | MIT Commits ------- 7c4f921 Remove deprecated code
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.