[DependencyInjection] Fail when dumping a Definition with no class nor factory #15083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
fix-decorated-services
branch
from
f46fb34 to
b781adb
Compare
nicolas-grekas
changed the title
Member
Author
|
ping @symfony/deciders |
nicolas-grekas
force-pushed
the
fix-decorated-services
branch
from
b781adb to
23ad4ad
Compare
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 28, 2015
…no class nor factory (nicolas-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [DependencyInjection] Fail when dumping a Definition with no class nor factory | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I tried creating an anonymous inline service with a DefinitionDecorator, but that did not work. Here is the fix. Commits ------- 23ad4ad [DependencyInjection] Fail when dumping a Definition with no class nor factory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried creating an anonymous inline service with a DefinitionDecorator, but that did not work.
Here is the fix.