-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Removed templating.helper.assets service configuration #14956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Why we need to delete the service? Do you know? |
|
There has been quit some refactoring due to the Asset Component, so there is a new service available, |
|
Yes, but |
|
Good point, this must be validated, I was just following that up based on the referenced PR. It would be great if someone could provide further feedback, I was just removing the configuration, the actual service has been removed alfready before. |
|
hmm, looks like the there is templating helper based on the new component. This looks like a mistake. |
|
@stof sorry, i don't understand what you're saying.. |
|
What he means is that it seems to be wrong for him, that there is no AssetsHelper based on the new component. @fabpot The current deprecation message relates just to the new Asset Component. The Asset component however has no such helper. Do you want to have a helper again in the asset component with the same functionality? What was the intention? The decision should be reflected in the docs. |
|
@peterrehm Thanks for the explanation :) IMO we should keep the helper, see #14972. |
|
@dosten So I would assume this PR should be fine, as this is deprecating the helper service not the Helper which will be eventually moved to another component which is however at the current moment already removed. |
Relates to #14940