Skip to content

Documented minor BC break introduced in AssetHelper #14940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
peterrehm wants to merge 2 commits into from
Closed

Documented minor BC break introduced in AssetHelper #14940

peterrehm wants to merge 2 commits into from

Conversation

@peterrehm
Copy link
Contributor

@peterrehm peterrehm commented Jun 11, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #14898
License MIT
Doc PR -

This should be an easy fix. As this AssetHelper is removed in 3.0 I think no correction for 3.0 would be needed.

@stof
Copy link
Member

stof commented Jun 11, 2015

👍

1 similar comment
@xabbuh
Copy link
Member

xabbuh commented Jun 11, 2015

👍

@fabpot
Copy link
Member

fabpot commented Jun 11, 2015

That's really just a hack to make things work. So, we should probably trigger some error notices when methods from the old class are called. And anyway, calling any of these methods will lead to some fatal errors as the original constructor is not called, so the properties are not initialized.

👎

@peterrehm
Copy link
Contributor Author

peterrehm commented Jun 11, 2015

There are several ways how this could adjusted further:

  1. Overwrite the other methods of the old service and trigger deprecation messages
  2. Try to return the old service
  3. Accept the minor BC break (It looks like it does not affect many at all) and just add that to the upgrade description

@fabpot
Copy link
Member

fabpot commented Jun 11, 2015

3 looks like the better idea.

@peterrehm
Copy link
Contributor Author

peterrehm commented Jun 11, 2015

@fabpot Just updated. I am wondering if I updated that correctly, will the templating.helper.assets really be removed in 3.0. It is still in the template_php.xml but the actual helper class is not any more there in the master branch.

I assumed this for now and would update accordingly, the way as it was phrased before recommended anyway the use of the asset.packages service.

@peterrehm peterrehm changed the title Fixed BC break introduced in AssetHelper Document minor BC break introduced in AssetHelper Jun 11, 2015
@peterrehm peterrehm changed the title Document minor BC break introduced in AssetHelper Documented minor BC break introduced in AssetHelper Jun 11, 2015
@fabpot
Copy link
Member

fabpot commented Jun 11, 2015

👍

@fabpot
Copy link
Member

fabpot commented Jun 11, 2015

Thank you @peterrehm.

fabpot added a commit that referenced this pull request Jun 11, 2015
@fabpot
minor #14940 Documented minor BC break introduced in AssetHelper (pet…
72782bb 
…errehm)

This PR was squashed before being merged into the 2.7 branch (closes #14940).

Discussion
----------

Documented minor BC break introduced in AssetHelper

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #14898
| License       | MIT
| Doc PR        | -

This should be an easy fix. As this AssetHelper is removed in 3.0 I think no correction for 3.0 would be needed.

Commits
-------

777dc45 Documented minor BC break introduced in AssetHelper
@fabpot fabpot closed this Jun 11, 2015
@peterrehm peterrehm deleted the assets-helper branch June 12, 2015 00:52
@peterrehm peterrehm mentioned this pull request Jun 12, 2015
Closed
@dosten dosten mentioned this pull request Jun 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peterrehm @stof @xabbuh @fabpot