[DebugBundle] Use output mechanism of dumpers instead of echoing #14631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
My bad: should be merged on 2.6! |
nicolas-grekas
force-pushed
the
dumper-dest
branch
from
79d3b57 to
1388701
Compare
nicolas-grekas
force-pushed
the
dumper-dest
branch
from
1388701 to
e14db39
Compare
fabpot
added a commit
that referenced
this pull request
May 15, 2015
…olas-grekas) This PR was merged into the 2.6 branch. Discussion ---------- [DebugBundle] Allow alternative destination for dumps | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14608 | License | MIT | Doc PR | - This PR fixes #14608 by adding a new `debug.dump_destination` configuration option to give users control over a stream destination where dumps will be written to. In HTTP mode, dumps are still/also collected in the toolbar. This supersedes #14627, #14631 and #14373 Commits ------- 5f255e5 [DebugBundle] Allow alternative destination for dumps 5368483 [DebugBundle] Use output mechanism of dumpers instead of echoing 8cb2abb [DebugBundle] Always collect dumps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using echo directly is wrong because dumpers can be configured to write anywhere.