Skip to content

[DX] Minor improvement for the translation:debug output #14473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolasdewez wants to merge 1 commit into from
Closed

[DX] Minor improvement for the translation:debug output #14473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
}

// Display header line
$headers = array('State(s)', 'Domain', 'Id', sprintf('Message Preview (%s)', $locale));
$headers = array('State', 'Domain', 'Id', sprintf('Message Preview (%s)', $locale));
foreach ($fallbackCatalogues as $fallbackCatalogue) {
$headers[] = sprintf('Fallback Message Preview (%s)', $fallbackCatalogue->getLocale());
}
Expand Down Expand Up @@ -208,26 +208,20 @@ protected function execute(InputInterface $input, OutputInterface $output)
} else {
$table->render($output);
}

$output->writeln('');
$output->writeln('<info>Legend:</info>');
$output->writeln(sprintf(' %s Missing message', $this->formatState(self::MESSAGE_MISSING)));
$output->writeln(sprintf(' %s Unused message', $this->formatState(self::MESSAGE_UNUSED)));
$output->writeln(sprintf(' %s Same as the fallback message', $this->formatState(self::MESSAGE_EQUALS_FALLBACK)));
}

private function formatState($state)
{
if (self::MESSAGE_MISSING === $state) {
return '<fg=red>x</>';
return '<error>missing</error>';
}

if (self::MESSAGE_UNUSED === $state) {
return '<fg=yellow>o</>';
return '<comment>unused</comment>';
}

if (self::MESSAGE_EQUALS_FALLBACK === $state) {
return '<fg=green>=</>';
return '<info>fallback</info>';
}

return $state;
Expand Down