[DependencyInjection] resolve class parameters in service factories #13924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I added tests based on #13930. |
fabpot
added a commit
that referenced
this pull request
Mar 15, 2015
… unit tests (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [DependencyInjection] `ResolveParameterPlaceHoldersPass` unit tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | When working #13924, I noticed that there were no tests for the `ResolveParameterPlaceHoldersPass` class. So I decided to add them for the `2.3` branch too. Commits ------- b8d42b3 `ResolveParameterPlaceHoldersPass` unit tests
Member
Author
|
And rebased given that #13930 has been merged. |
Member
|
👍 |
Member
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Mar 17, 2015
…factories (xabbuh) This PR was merged into the 2.6 branch. Discussion ---------- [DependencyInjection] resolve class parameters in service factories | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This is based on the parameter resolving for factories from #13519 and makes the necessary changes for the new factory syntax introduced in Symfony 2.6. @fabian In #13519, you also updated the `PhpDumper` to make use of `dumpValue()`. Should I do the same here (or in this case reopen #13455)? Commits ------- 8bda37c resolve class parameters in service factories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the parameter resolving for factories from #13519 and makes the necessary changes for the new factory syntax introduced in Symfony 2.6.
@fabian In #13519, you also updated the
PhpDumperto make use ofdumpValue(). Should I do the same here (or in this case reopen #13455)?