-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[DomCrawler] [2.7] Abstract URI logic and crawl images #13649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,222 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Component\DomCrawler; | ||
|
|
||
| /** | ||
| * Any HTML element that can link to an URI. | ||
| * | ||
| * @author Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| * @api | ||
| */ | ||
| abstract class AbstractUriElement implements UriElementInterface | ||
| { | ||
| /** | ||
| * @var \DOMElement | ||
| */ | ||
| protected $node; | ||
|
|
||
| /** | ||
| * @var string The method to use for the link | ||
| */ | ||
| protected $method; | ||
|
|
||
| /** | ||
| * @var string The URI of the page where the link is embedded (or the base href) | ||
| */ | ||
| protected $currentUri; | ||
|
|
||
| /** | ||
| * Constructor. | ||
| * | ||
| * @param \DOMElement $node A \DOMElement instance | ||
| * @param string $currentUri The URI of the page where the link is embedded (or the base href) | ||
| * @param string $method The method to use for the link (get by default) | ||
| * | ||
| * @throws \InvalidArgumentException if the node is not a link | ||
| * | ||
| * @api | ||
| */ | ||
| public function __construct(\DOMElement $node, $currentUri, $method = 'GET') | ||
| { | ||
| if (!in_array(strtolower(substr($currentUri, 0, 4)), array('http', 'file'))) { | ||
| throw new \InvalidArgumentException(sprintf('Current URI must be an absolute URL ("%s").', $currentUri)); | ||
| } | ||
|
|
||
| $this->setNode($node); | ||
| $this->method = $method ? strtoupper($method) : null; | ||
| $this->currentUri = $currentUri; | ||
| } | ||
|
|
||
| /** | ||
| * Gets the node associated with this link. | ||
| * | ||
| * @return \DOMElement A \DOMElement instance | ||
| */ | ||
| public function getNode() | ||
| { | ||
| return $this->node; | ||
| } | ||
|
|
||
| /** | ||
| * Gets the method associated with this link. | ||
| * | ||
| * @return string The method | ||
| * | ||
| * @api | ||
| */ | ||
| public function getMethod() | ||
| { | ||
| return $this->method; | ||
| } | ||
|
|
||
| /** | ||
| * Gets the URI associated with this link. | ||
| * | ||
| * @return string The URI | ||
| * | ||
| * @api | ||
| */ | ||
| public function getUri() | ||
| { | ||
| $uri = trim($this->getRawUri()); | ||
|
|
||
| // absolute URL? | ||
| if (null !== parse_url($uri, PHP_URL_SCHEME)) { | ||
| return $uri; | ||
| } | ||
|
|
||
| // empty URI | ||
| if (!$uri) { | ||
| return $this->currentUri; | ||
| } | ||
|
|
||
| // an anchor | ||
| if ('#' === $uri[0]) { | ||
| return $this->cleanupAnchor($this->currentUri).$uri; | ||
| } | ||
|
|
||
| $baseUri = $this->cleanupUri($this->currentUri); | ||
|
|
||
| if ('?' === $uri[0]) { | ||
| return $baseUri.$uri; | ||
| } | ||
|
|
||
| // absolute URL with relative schema | ||
| if (0 === strpos($uri, '//')) { | ||
| return preg_replace('#^([^/]*)//.*$#', '$1', $baseUri).$uri; | ||
| } | ||
|
|
||
| $baseUri = preg_replace('#^(.*?//[^/]*)(?:\/.*)?$#', '$1', $baseUri); | ||
|
|
||
| // absolute path | ||
| if ('/' === $uri[0]) { | ||
| return $baseUri.$uri; | ||
| } | ||
|
|
||
| // relative path | ||
| $path = parse_url(substr($this->currentUri, strlen($baseUri)), PHP_URL_PATH); | ||
| $path = $this->canonicalizePath(substr($path, 0, strrpos($path, '/')).'/'.$uri); | ||
|
|
||
| return $baseUri.('' === $path || '/' !== $path[0] ? '/' : '').$path; | ||
| } | ||
|
|
||
| /** | ||
| * Returns raw URI data. | ||
| * | ||
| * @return string | ||
| */ | ||
| abstract protected function getRawUri(); | ||
|
|
||
| /** | ||
| * Returns the canonicalized URI path (see RFC 3986, section 5.2.4). | ||
| * | ||
| * @param string $path URI path | ||
| * | ||
| * @return string | ||
| */ | ||
| protected function canonicalizePath($path) | ||
| { | ||
| if ('' === $path || '/' === $path) { | ||
| return $path; | ||
| } | ||
|
|
||
| if ('.' === substr($path, -1)) { | ||
| $path .= '/'; | ||
| } | ||
|
|
||
| $output = array(); | ||
|
|
||
| foreach (explode('/', $path) as $segment) { | ||
| if ('..' === $segment) { | ||
| array_pop($output); | ||
| } elseif ('.' !== $segment) { | ||
| array_push($output, $segment); | ||
| } | ||
| } | ||
|
|
||
| return implode('/', $output); | ||
| } | ||
|
|
||
| /** | ||
| * Sets current \DOMElement instance. | ||
| * | ||
| * @param \DOMElement $node A \DOMElement instance | ||
| * | ||
| * @throws \LogicException If given node is not an anchor | ||
| */ | ||
| abstract protected function setNode(\DOMElement $node); | ||
|
|
||
| /** | ||
| * Removes the query string and the anchor from the given uri. | ||
| * | ||
| * @param string $uri The uri to clean | ||
| * | ||
| * @return string | ||
| */ | ||
| private function cleanupUri($uri) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and same below
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These functions were not introduced by this PR, do you think it's still relevant I rename them here? |
||
| { | ||
| return $this->cleanupQuery($this->cleanupAnchor($uri)); | ||
| } | ||
|
|
||
| /** | ||
| * Remove the query string from the uri. | ||
| * | ||
| * @param string $uri | ||
| * | ||
| * @return string | ||
| */ | ||
| private function cleanupQuery($uri) | ||
| { | ||
| if (false !== $pos = strpos($uri, '?')) { | ||
| return substr($uri, 0, $pos); | ||
| } | ||
|
|
||
| return $uri; | ||
| } | ||
|
|
||
| /** | ||
| * Remove the anchor from the uri. | ||
| * | ||
| * @param string $uri | ||
| * | ||
| * @return string | ||
| */ | ||
| private function cleanupAnchor($uri) | ||
| { | ||
| if (false !== $pos = strpos($uri, '#')) { | ||
| return substr($uri, 0, $pos); | ||
| } | ||
|
|
||
| return $uri; | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Component\DomCrawler; | ||
|
|
||
| /** | ||
| * Image represents an HTML image (an HTML img tag). | ||
| * | ||
| * @api | ||
| */ | ||
| class Image extends AbstractUriElement | ||
| { | ||
| public function __construct(\DOMElement $node, $currentUri) | ||
| { | ||
| parent::__construct($node, $currentUri); | ||
| } | ||
|
|
||
| protected function getRawUri() | ||
| { | ||
| return $this->node->getAttribute('src'); | ||
| } | ||
|
|
||
| protected function setNode(\DOMElement $node) | ||
| { | ||
| if ('img' !== $node->nodeName) { | ||
| throw new \LogicException(sprintf('Unable to visualize a "%s" tag.', $node->nodeName)); | ||
| } | ||
|
|
||
| $this->node = $node; | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All
@apitags must be removed, we don't use them anymore.