Skip to content

Conversation

@Tobion
Copy link
Contributor

@Tobion Tobion commented Jan 15, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

The markdown descriptor for routes missed brackets, so that the options where actually ignored. Also fixed some other inconsistencies.

@Tobion
Copy link
Contributor Author

Tobion commented Jan 15, 2015

@fabpot please merge 2.5 up to master then. So that I can rebase #13396.

@fabpot
Copy link
Member

fabpot commented Jan 15, 2015

Thank you @Tobion.

@fabpot fabpot merged commit b0c29a0 into symfony:2.5 Jan 15, 2015
fabpot added a commit that referenced this pull request Jan 15, 2015
This PR was merged into the 2.5 branch.

Discussion
----------

[FrameworkBundle] fix routing descriptor for options

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

The markdown descriptor for routes missed brackets, so that the `options` where actually ignored. Also fixed some other inconsistencies.

Commits
-------

b0c29a0 [FrameworkBundle] fix routing descriptor for options
@fabpot
Copy link
Member

fabpot commented Jan 15, 2015

merged in all branches now.

@Tobion Tobion deleted the fix-routing-descriptor branch January 15, 2015 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants