[HttpKernel] Fixed Kernel::getContainerClass, to prevent invalid PHP class name #13412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fordidden char for a class name
lyrixx
changed the title
lyrixx
force-pushed
the
fix-kernel-get-name
branch
2 times, most recently
from
a43c1c8 to
a9c1bcc
Compare
lyrixx
force-pushed
the
fix-kernel-get-name
branch
from
a9c1bcc to
d86c404
Compare
jderusse
added a commit
to sensiolabs/melody
that referenced
this pull request
Jan 15, 2015
This PR was merged into the master branch. Discussion ---------- Prefix the working directory hash to avoid weird issue Some application use `basename(__DIR__)` and may generate class name with this dirname. And a sha256 hash may start with a number. This will lead to a fatal error because PHP forbid that. see symfony/symfony#13412 for a related issue Commits ------- a72b7a6 Prefix the working directory hash to avoid weird issue
Contributor
There was a problem hiding this comment.
If I have the following 3 applications, will it still work after this change? Wouldn't it be better to just prefix something?
1app2app3app
Member
Author
There was a problem hiding this comment.
Good point. But right now, this "feature" is not supported.
Member
There was a problem hiding this comment.
I don't think we need to support these edge cases... especially now that Melody has been fixed. it adds a regex for every single request and makes the code less readable.
Member
There was a problem hiding this comment.
thus, if we fix it here, we need to fix it for the other dumped classes (the url matcher and the url generator)
Member
Author
There was a problem hiding this comment.
ok. no problem. I close the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the folder which contains the kernel begin with a number, symfony will crash because symfony will create a container class starting with a number.
I'm not sure if I should fix thegetNamemethod, or only thegetContainerClass().More over, if the
environmentcontains some invalid characters, it should be fixed too.Actually, I sanitaze only the
getContainerClassmethod. I did not squashed my commit if I need to revert ;)