Skip to content

Conversation

@fabpot
Copy link
Member

@fabpot fabpot commented Jan 14, 2015

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you can also remove the complexType name="form"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixed

@fabpot fabpot force-pushed the twig-deprecated-removal branch 2 times, most recently from a163635 to 9994c02 Compare January 16, 2015 07:22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this property is still referenced in getUser

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Tobion
Copy link
Contributor

Tobion commented Jan 16, 2015

apart from comment above, 👍

@fabpot fabpot force-pushed the twig-deprecated-removal branch from 9994c02 to 2afd614 Compare January 16, 2015 07:41
@fabpot fabpot merged commit 2afd614 into symfony:master Jan 16, 2015
fabpot added a commit that referenced this pull request Jan 16, 2015
This PR was merged into the 3.0-dev branch.

Discussion
----------

removed deprecated Twig features

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

2afd614 removed deprecated Twig features
@fabpot fabpot deleted the twig-deprecated-removal branch February 12, 2015 09:34
@fabpot fabpot mentioned this pull request Nov 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants