Skip to content

[3.0][EventDispatcher][Event] removed deprecated methods #13260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 2 commits into from
Jan 16, 2015
Merged

[3.0][EventDispatcher][Event] removed deprecated methods #13260

fabpot merged 2 commits into from
Jan 16, 2015

Conversation

@aitboudad
Copy link
Contributor

@aitboudad aitboudad commented Jan 5, 2015

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Fixed tickets ~
Tests pass? yes
License MIT

@hhamon
Copy link
Contributor

hhamon commented Jan 5, 2015

Can you please also update the PR to remove the setName and  getName methods as well? I don't know if removing these two methods has lots of impact elsewhere or not.

@aitboudad aitboudad changed the title [3.0][EventDispatcher][Event] removed deprecated set & get Dispatcher [3.0][EventDispatcher][Event] removed deprecated methods Jan 5, 2015
@aitboudad aitboudad force-pushed the event-dispatcher branch 4 times, most recently from 5c83678 to 5ee2578 Compare January 7, 2015 13:03
@fabpot
Copy link
Member

fabpot commented Jan 16, 2015

👍

@stof
Copy link
Member

stof commented Jan 16, 2015

👍

@fabpot
Copy link
Member

fabpot commented Jan 16, 2015

Thank you @aitboudad.

@fabpot fabpot merged commit 4ab3e8b into symfony:master Jan 16, 2015
fabpot added a commit that referenced this pull request Jan 16, 2015
@fabpot
feature #13260 [3.0][EventDispatcher][Event] removed deprecated metho…
9f195cd 
…ds (aitboudad)

This PR was merged into the 3.0-dev branch.

Discussion
----------

[3.0][EventDispatcher][Event] removed deprecated methods

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Fixed tickets  | ~
| Tests pass?   | yes
| License       | MIT

Commits
-------

4ab3e8b [3.0] [EventDispatcher][Event] removed deprecated name methods.
ba70a48 [3.0] [EventDispatcher][Event] removed deprecated setDispatcher and getDispatcher methods.
@aitboudad aitboudad deleted the event-dispatcher branch January 16, 2015 13:24
@fabpot fabpot mentioned this pull request Nov 16, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

EventDispatcher

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aitboudad @hhamon @fabpot @stof