[2.7] [Bridge] [Swiftmailer] adds deprecation notice on MessageDataCollector class. #13056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hhamon
commented
Dec 20, 2014
hhamon
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
Member
There was a problem hiding this comment.
I would move the trigger at the top of the class like done in other deprecated classes. Also, can you put the message on one line only? You can replace the class name with __CLASS__ to make it a bit shorter and instead of giving the URL to pakcagist, just mention the package name.
hhamon
force-pushed
the
bridge-swiftmailer-deprecation-notice
branch
from
a92fbf5 to
c003bb1
Compare
Contributor
Author
|
@fabpot changes have been applied. |
hhamon
changed the title
Member
|
Thank you @hhamon. |
fabpot
added a commit
that referenced
this pull request
Dec 21, 2014
…MessageDataCollector class. (hhamon) This PR was merged into the 2.7 branch. Discussion ---------- [2.7] [Bridge] [Swiftmailer] adds deprecation notice on MessageDataCollector class. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- c003bb1 [Bridge] [Swiftmailer] adds deprecation notice on MessageDataCollector class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.