Skip to content

[WIP][DX] Better exception page #12363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hason wants to merge 4 commits into from
Closed

[WIP][DX] Better exception page #12363

hason wants to merge 4 commits into from

Conversation

@hason
Copy link
Contributor

@hason hason commented Oct 30, 2014

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass?
Fixed tickets
License MIT
Doc PR
  • add twig files into stack trace
  • add syntax highlighters for PHP and Twig with symfony.com's color scheme
  • use VarDumper for function arguments (maybe in another PR)
  • add tests

Before:
before

After:
after

@weaverryan
Copy link
Member

weaverryan commented Oct 31, 2014

Woh, the before and after is amazing! Great idea - especially the Twig inclusion.

fabpot
fabpot reviewed Oct 31, 2014
View reviewed changes
src/Symfony/Bridge/Twig/CHANGELOG.md Outdated
Copy link
Member

@fabpot fabpot Oct 31, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's going to be in 2.7. 2.6 is closed for new features.

@peterrehm
Copy link
Contributor

peterrehm commented Nov 2, 2014

@hason It looks awesome. In the after screenshot there is a line break in the PHP code line 4701. I would prefer if you make the area to scroll instead of the line break.

stof
stof reviewed Nov 21, 2014
View reviewed changes
src/Symfony/Bridge/Twig/Debug/TwigHighlighter.php
Copy link
Member

@stof stof Nov 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be private

@hason hason mentioned this pull request Dec 30, 2014
Closed
ghost
ghost reviewed May 5, 2015
View reviewed changes
src/Symfony/Bundle/TwigBundle/Resources/views/Exception/traces.html.twig
Copy link

@ghost ghost May 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the same twig cycle technique you used below for inline style this also? and thus make it a class?

@weaverryan
Copy link
Member

weaverryan commented Jun 29, 2015

@hason do you have some time to update this PR for the suggested changes? I'd still like to see this, e.g. for 2.8.

Thanks!

@Koc Koc mentioned this pull request Aug 13, 2015
Closed
@javiereguiluz javiereguiluz mentioned this pull request Aug 13, 2015
Closed
8 tasks
@fabpot
Copy link
Member

fabpot commented Sep 14, 2015

@hason Do you time to finish this one? Or perhaps @javiereguiluz can take over?

@hason hason mentioned this pull request Sep 14, 2015
Closed
4 tasks
@hason
Copy link
Contributor Author

hason commented Sep 14, 2015

Closing in favour of #15792.

@hason hason closed this Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hason @weaverryan @peterrehm @fabpot @stof