[FrameworkBundle] [DX] Displays friendly message if the event does not have any registered listeners #12216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieuauger
changed the title
Contributor
|
It should not be an exception but a notice of some kind. See symfony/symfony-docs#4265 |
Member
|
I agree that it should not be an exception. Not having any listener registered does not mean it is a failure |
Contributor
Author
|
Thanks, I didn't know there was an initiative for console style, this is great. I should wait for #12035 |
Member
|
@matthieuauger Any news on this PR? |
Contributor
Author
|
I was waiting for symfony/symfony-docs#4265 but it seems to be dead. |
matthieuauger
force-pushed
the
debug-event-dispatcher-unkown-event
branch
2 times, most recently
from
dab62b7 to
5161a7e
Compare
Contributor
Author
|
I updated the PR to display a message instead of an exception. I followed the Console Style Guide for the formatting. Any feedbacks welcome
The PR is currently headed to master, but I think it should be merged in 2.6. Tell me if you want me to create another PR |
matthieuauger
force-pushed
the
debug-event-dispatcher-unkown-event
branch
from
5161a7e to
8bb9302
Compare
Member
|
Thank you @matthieuauger. |
fabpot
added a commit
that referenced
this pull request
Mar 26, 2015
…event does not have any registered listeners (matthieuauger) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #12216). Discussion ---------- [FrameworkBundle] [DX] Displays friendly message if the event does not have any registered listeners | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT Currently if you run debug:event-dispatcher on an event without registered listeners, the output looks like this  This PR just add a friendly message like debug:container or debug:router :  Commits ------- a5628bd Displays friendly message if the event does not have any registered listeners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you run debug:event-dispatcher on an event without registered listeners, the output looks like this
This PR just add a friendly message like debug:container or debug:router :