[Templating] refactored asset packages #1047
Conversation
Added support for a configurable format string used to apply version to a path (defaults to '%s?%s'). Moved base url/base path logic to packages.
|
I'd like to see this merged before the next release. Can we review sometime soon? |
|
I'd also raise the question of why request scope was added here? I have a similar issue to @jmikola. It may be that asset URLs can be dependent on whether a current request is secure, but if a request is not present (i.e. this is a CLI script) can we not either assume an HTTP default for the protocol, or provide an easy way to determine which protocol should be used in URL generation? (Would be happy to look into code/ submit a PR if there is a consensus that there is an ongoing problem here, and no workround I'm not aware of.) |
|
@shieldo: I developed a work-around some time ago: #2223 If you configure your asset packages to use SSL for all of their base URL's, request scoping will not be introduced. The individual, named asset packages will not have a request scope (see: |
ghost
mentioned this pull request
6 participants
I've refactored asset packages. These are the two main benefits:
%s?%sbut could also be set to (for example)release-%2$s/%1$sif you want to move the version into the pathThe following methods have been removed from the assets helper, but I can patch them back in if this is an issue:
getBasePath()setBasePath()getBaseUrl($path)