-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Closed
Description
Symfony version(s) affected
5.4.15
Description
The HttpClient implementation only cares if ConnectionLimitingPool is defined:
| if ($amp = class_exists(ConnectionLimitingPool::class)) { |
However, this tells nothing of whether this is a version of Amp using coroutines (v1-4) or fibers (v5+). Both versions declare ConnectionLimitingPool, so this doesn't distinguish between versions and if the user has installed Amp HTTP client v5, it will fail.
How to reproduce
Try to send a request using HttpClient with amphp/http-client:^5@beta installed.
Possible Solution
Either directly support Amp HTTP client v5 or find a better detection method that rejects such version.
Additional Context
No response