-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Closed
Labels
Description
See #38177 (comment) :
this should indeed be a pool based on
cache.apprather than usingcache.appdirectly, to avoid key conflicts (keys must be unique inside the pool, so sharing the same pool between multiple places is a bad idea as they need to cooperate on their naming of keys)
seefor the service definition of an existing onesymfony/src/Symfony/Bundle/FrameworkBundle/Resources/config/cache.php
Lines 68 to 71 in f06f2f0
->set('cache.messenger.restart_workers_signal') ->parent('cache.app') ->private() ->tag('cache.pool')
In the rate limiter config, we're also using cache.app directly. This should be changed to using a custom cache pool:
symfony/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Lines 1809 to 1812 in e8dd14a
| ->scalarNode('cache_pool') | |
| ->info('The cache pool to use for storing the current limiter state') | |
| ->defaultValue('cache.app') | |
| ->end() |