[Console] use STDOUT/ERR in ConsoleOutput to save opening too many file descriptors

nicolas-grekas · nicolas-grekas · commit fd7b1b0575ce · 2022-01-18T10:15:25.000+01:00
diff --git a/src/Symfony/Component/Console/Output/ConsoleOutput.php b/src/Symfony/Component/Console/Output/ConsoleOutput.php
@@ -153,14 +153,18 @@ private function openOutputStream()
             return fopen('php://output', 'w');
         }
 
-        return @fopen('php://stdout', 'w') ?: fopen('php://output', 'w');
+        return \defined('STDOUT') ? \STDOUT : (@fopen('php://stdout', 'w') ?: fopen('php://output', 'w'));
     }
 
     /**
      * @return resource
      */
     private function openErrorStream()
     {
-        return fopen($this->hasStderrSupport() ? 'php://stderr' : 'php://output', 'w');
+        if (!$this->hasStderrSupport()) {
+            return fopen('php://output', 'w');
+        }
+
+        return \defined('STDERR') ? \STDERR : (@fopen('php://stderr', 'w') ?: fopen('php://output', 'w'));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -153,14 +153,18 @@ private function openOutputStream()`
`153`	`153`	`return fopen('php://output', 'w');`
`154`	`154`	`}`
`155`	`155`
`156`		`- return @fopen('php://stdout', 'w') ?: fopen('php://output', 'w');`
	`156`	`+ return \defined('STDOUT') ? \STDOUT : (@fopen('php://stdout', 'w') ?: fopen('php://output', 'w'));`
`157`	`157`	`}`
`158`	`158`
`159`	`159`	`/**`
`160`	`160`	`* @return resource`
`161`	`161`	`*/`
`162`	`162`	`private function openErrorStream()`
`163`	`163`	`{`
`164`		`- return fopen($this->hasStderrSupport() ? 'php://stderr' : 'php://output', 'w');`
	`164`	`+ if (!$this->hasStderrSupport()) {`
	`165`	`+ return fopen('php://output', 'w');`
	`166`	`+ }`
	`167`	`+`
	`168`	`+ return \defined('STDERR') ? \STDERR : (@fopen('php://stderr', 'w') ?: fopen('php://output', 'w'));`
`165`	`169`	`}`
`166`	`170`	`}`