[FrameworkBundle] Rename service notifier.logger_notification_listener to notifier.notification_logger_listener

ker0x · nicolas-grekas · commit fcbfbb185c94 · 2023-01-09T12:13:14.000+01:00
diff --git a/UPGRADE-6.3.md b/UPGRADE-6.3.md
@@ -38,6 +38,11 @@ FrameworkBundle
    </framework:config>
    ```
 
+FrameworkBundle
+---------------
+
+ * Deprecate the `notifier.logger_notification_listener` service, use the `notifier.notification_logger_listener` service instead
+
 HttpKernel
 ----------
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md b/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
@@ -9,6 +9,7 @@ CHANGELOG
  * Add `--format` option to the `debug:config` command
  * Add support to pass namespace wildcard in `framework.messenger.routing`
  * Deprecate `framework:exceptions` tag, unwrap it and replace `framework:exception` tags' `name` attribute by `class`
+ * Deprecate the `notifier.logger_notification_listener` service, use the `notifier.notification_logger_listener` service instead
 
 6.2
 ---
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/notifier.php b/src/Symfony/Bundle/FrameworkBundle/Resources/config/notifier.php
@@ -126,7 +126,11 @@
             ->args([service('texter.transports')])
             ->tag('messenger.message_handler', ['handles' => PushMessage::class])
 
-        ->set('notifier.logger_notification_listener', NotificationLoggerListener::class)
+        ->set('notifier.notification_logger_listener', NotificationLoggerListener::class)
             ->tag('kernel.event_subscriber')
+
+        ->alias('notifier.logger_notification_listener', 'notifier.notification_logger_listener')
+            ->deprecate('symfony/framework-bundle', '6.3', 'The "%alias_id%" service is deprecated, use "notifier.notification_logger_listener" instead.')
+
     ;
 };
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/notifier_debug.php b/src/Symfony/Bundle/FrameworkBundle/Resources/config/notifier_debug.php
@@ -16,7 +16,7 @@
 return static function (ContainerConfigurator $container) {
     $container->services()
         ->set('notifier.data_collector', NotificationDataCollector::class)
-            ->args([service('notifier.logger_notification_listener')])
+            ->args([service('notifier.notification_logger_listener')])
             ->tag('data_collector', ['template' => '@WebProfiler/Collector/notifier.html.twig', 'id' => 'notifier'])
     ;
 };
diff --git a/src/Symfony/Bundle/FrameworkBundle/Test/NotificationAssertionsTrait.php b/src/Symfony/Bundle/FrameworkBundle/Test/NotificationAssertionsTrait.php
@@ -91,8 +91,8 @@ public static function getNotifierMessage(int $index = 0, string $transportName
     public static function getNotificationEvents(): NotificationEvents
     {
         $container = static::getContainer();
-        if ($container->has('notifier.logger_notification_listener')) {
-            return $container->get('notifier.logger_notification_listener')->getEvents();
+        if ($container->has('notifier.notification_logger_listener')) {
+            return $container->get('notifier.notification_logger_listener')->getEvents();
         }
 
         static::fail('A client must have Notifier enabled to make notifications assertions. Did you forget to require symfony/notifier?');

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`	`return static function (ContainerConfigurator $container) {`
`17`	`17`	`$container->services()`
`18`	`18`	`->set('notifier.data_collector', NotificationDataCollector::class)`
`19`		`- ->args([service('notifier.logger_notification_listener')])`
	`19`	`+ ->args([service('notifier.notification_logger_listener')])`
`20`	`20`	`->tag('data_collector', ['template' => '@WebProfiler/Collector/notifier.html.twig', 'id' => 'notifier'])`
`21`	`21`	`;`
`22`	`22`	`};`
Original file line number	Diff line number	Diff line change
`@@ -91,8 +91,8 @@ public static function getNotifierMessage(int $index = 0, string $transportName`
`91`	`91`	`public static function getNotificationEvents(): NotificationEvents`
`92`	`92`	`{`
`93`	`93`	`$container = static::getContainer();`
`94`		`- if ($container->has('notifier.logger_notification_listener')) {`
`95`		`- return $container->get('notifier.logger_notification_listener')->getEvents();`
	`94`	`+ if ($container->has('notifier.notification_logger_listener')) {`
	`95`	`+ return $container->get('notifier.notification_logger_listener')->getEvents();`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`static::fail('A client must have Notifier enabled to make notifications assertions. Did you forget to require symfony/notifier?');`