bug #46847 [Serializer] Cannot use Context attribute context in AdvancedNameConverterInterface::denormalize (ogizanagi)

fabpot · fabpot · commit fc4e19b71052 · 2022-07-04T21:58:44.000+02:00
This PR was merged into the 6.2 branch. Discussion ---------- [Serializer] Cannot use Context attribute context in AdvancedNameConverterInterface::denormalize | Q | A | ------------- | --- | Branch? | 6.2  | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | Fix #46680  | License | MIT | Doc PR | N/A I realized we can't use the `Context` attribute context in an `AdvancedNameConverterInterface::denormalize`, same as spotted already in 5.4 in #46525. Also adds the missing CHANGELOG entry for #46680 Commits ------- c99082c [Serializer] Cannot use @context context in AdvancedNameConverterInterface::denormalize
diff --git a/src/Symfony/Component/Serializer/CHANGELOG.md b/src/Symfony/Component/Serializer/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+6.2
+---
+
+* Add support for constructor promoted properties to `Context` attribute
+
 6.1
 ---
 
diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
@@ -334,8 +334,8 @@ protected function instantiateObject(array &$data, string $class, array &$contex
             $params = [];
             foreach ($constructorParameters as $constructorParameter) {
                 $paramName = $constructorParameter->name;
-                $attributeContext = $this->getAttributeDenormalizationContext($class, $paramName, $context);
-                $key = $this->nameConverter ? $this->nameConverter->normalize($paramName, $class, $format, $attributeContext) : $paramName;
+                $key = $this->nameConverter ? $this->nameConverter->normalize($paramName, $class, $format, $context) : $paramName;
+                $attributeContext = $this->getAttributeDenormalizationContext($class, $key, $context);
 
                 $allowed = false === $allowedAttributes || \in_array($paramName, $allowedAttributes);
                 $ignored = !$this->isAllowedAttribute($class, $paramName, $format, $context);
