minor #51727 Remove setAccessible reflection call in tests (alamirault)

fabpot · fabpot · commit fbf6f56ca732 · 2023-09-24T14:11:59.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- Remove `setAccessible` reflection call in tests | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no  | Deprecations? | no  | Tickets | Fix #...  | License | MIT | Doc PR | symfony/symfony-docs#...  I checked all codebase, and found only this occurence when php >8.1 is required > Note: As of PHP 8.1.0, calling this method has no effect; all methods are invokable by default. https://www.php.net/manual/en/reflectionmethod.setaccessible https://www.php.net/manual/en/reflectionproperty.setaccessible.php Commits ------- 8371c92 Remove setAccessible reflection call in tests
diff --git a/src/Symfony/Bridge/PsrHttpMessage/Tests/Factory/HttpFoundationFactoryTest.php b/src/Symfony/Bridge/PsrHttpMessage/Tests/Factory/HttpFoundationFactoryTest.php
@@ -208,7 +208,6 @@ private function callCreateUploadedFile(UploadedFileInterface $uploadedFile): Ht
     {
         $reflection = new \ReflectionClass($this->factory);
         $createUploadedFile = $reflection->getMethod('createUploadedFile');
-        $createUploadedFile->setAccessible(true);
 
         return $createUploadedFile->invokeArgs($this->factory, [$uploadedFile]);
     }

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,6 @@ private function callCreateUploadedFile(UploadedFileInterface $uploadedFile): Ht`
`208`	`208`	`{`
`209`	`209`	`$reflection = new \ReflectionClass($this->factory);`
`210`	`210`	`$createUploadedFile = $reflection->getMethod('createUploadedFile');`
`211`		`- $createUploadedFile->setAccessible(true);`
`212`	`211`
`213`	`212`	`return $createUploadedFile->invokeArgs($this->factory, [$uploadedFile]);`
`214`	`213`	`}`