[LDAP] Fixing missing 'user_identifier' forward compatibility in CheckLdapCredentialsListener

EXT - THERAGE Kevin · EXT - THERAGE Kevin · commit f8cc63fbfb6b · 2022-06-15T15:10:41.000+02:00
diff --git a/src/Symfony/Component/Ldap/Security/CheckLdapCredentialsListener.php b/src/Symfony/Component/Ldap/Security/CheckLdapCredentialsListener.php
@@ -85,7 +85,7 @@ public function onCheckPassport(CheckPassportEvent $event)
                 }
                 // @deprecated since Symfony 5.3, change to $user->getUserIdentifier() in 6.0
                 $username = $ldap->escape(method_exists($user, 'getUserIdentifier') ? $user->getUserIdentifier() : $user->getUsername(), '', LdapInterface::ESCAPE_FILTER);
-                $query = str_replace('{username}', $username, $ldapBadge->getQueryString());
+                $query = str_replace(['{username}', '{user_identifier}'], $username, $ldapBadge->getQueryString());
                 $result = $ldap->query($ldapBadge->getDnString(), $query)->execute();
                 if (1 !== $result->count()) {
                     throw new BadCredentialsException('The presented username is invalid.');

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ public function onCheckPassport(CheckPassportEvent $event)`
`85`	`85`	`}`
`86`	`86`	`// @deprecated since Symfony 5.3, change to $user->getUserIdentifier() in 6.0`
`87`	`87`	`$username = $ldap->escape(method_exists($user, 'getUserIdentifier') ? $user->getUserIdentifier() : $user->getUsername(), '', LdapInterface::ESCAPE_FILTER);`
`88`		`- $query = str_replace('{username}', $username, $ldapBadge->getQueryString());`
	`88`	`+ $query = str_replace(['{username}', '{user_identifier}'], $username, $ldapBadge->getQueryString());`
`89`	`89`	`$result = $ldap->query($ldapBadge->getDnString(), $query)->execute();`
`90`	`90`	`if (1 !== $result->count()) {`
`91`	`91`	`throw new BadCredentialsException('The presented username is invalid.');`