dump non UTF-8 encoded strings as binary data

xabbuh · xabbuh · commit f7cdab3f6df4 · 2016-03-29T22:14:55.000+02:00
diff --git a/src/Symfony/Component/Yaml/CHANGELOG.md b/src/Symfony/Component/Yaml/CHANGELOG.md
@@ -4,14 +4,14 @@ CHANGELOG
 3.1.0
 -----
 
+ * Strings that are not UTF-8 encoded will be dumped as base64 encoded binary
+   data.
+
  * Added support for dumping multi line strings as literal blocks.
 
  * Added support for parsing base64 encoded binary data when they are tagged
    with the `!!binary` tag.
 
- * Added support for dumping binary data as base64 encoded strings by passing
-   the `Yaml::DUMP_BASE64_BINARY_DATA` flag.
-
  * Added support for parsing timestamps as `\DateTime` objects:
 
    ```php
diff --git a/src/Symfony/Component/Yaml/Inline.php b/src/Symfony/Component/Yaml/Inline.php
@@ -201,7 +201,7 @@ public static function dump($value, $flags = 0)
                 return $repr;
             case '' == $value:
                 return "''";
-            case Yaml::DUMP_BASE64_BINARY_DATA & $flags && self::isBinaryString($value):
+            case self::isBinaryString($value):
                 return '!!binary '.base64_encode($value);
             case Escaper::requiresDoubleQuoting($value):
                 return Escaper::escapeWithDoubleQuotes($value);
@@ -627,7 +627,7 @@ public static function evaluateBinaryScalar($scalar)
 
     private static function isBinaryString($value)
     {
-        return preg_match('/[^\x09-\x0d\x20-\xff]/', $value);
+        return !preg_match('//u', $value);
     }
 
     /**
diff --git a/src/Symfony/Component/Yaml/Tests/DumperTest.php b/src/Symfony/Component/Yaml/Tests/DumperTest.php
@@ -277,14 +277,6 @@ public function getEscapeSequences()
         );
     }
 
-    public function testBinaryDataIsDumpedAsIsWithoutFlag()
-    {
-        $binaryData = file_get_contents(__DIR__.'/Fixtures/arrow.gif');
-        $expected = "{ data: '".str_replace("'", "''", $binaryData)."' }";
-
-        $this->assertSame($expected, $this->dumper->dump(array('data' => $binaryData)));
-    }
-
     public function testBinaryDataIsDumpedBase64EncodedWithFlag()
     {
         $binaryData = file_get_contents(__DIR__.'/Fixtures/arrow.gif');
@@ -293,6 +285,12 @@ public function testBinaryDataIsDumpedBase64EncodedWithFlag()
         $this->assertSame($expected, $this->dumper->dump(array('data' => $binaryData), 0, 0, Yaml::DUMP_BASE64_BINARY_DATA));
     }
 
+    public function testDumpingNonUtf8DataTriggersException()
+    {
+        // "für" (ISO-8859-1 encoded)
+        $this->assertSame('!!binary ZsM/cg==', $this->dumper->dump("f\xc3\x3fr"));
+    }
+
     /**
      * @dataProvider objectAsMapProvider
      */
