Add test and fix typo

dunglas · dunglas · commit f49fbc3d2c7b · 2016-01-19T08:53:40.000+01:00
diff --git a/src/Symfony/Component/Serializer/Normalizer/DateTimeNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DateTimeNormalizer.php
@@ -39,11 +39,13 @@ public function __construct($format = \DateTime::RFC3339)
 
     /**
      * {@inheritdoc}
+     *
+     * @throws InvalidArgumentException
      */
     public function normalize($object, $format = null, array $context = array())
     {
         if (!$object instanceof \DateTimeInterface) {
-            throw new InvalidArgumentException('The object must implements the "\DateTimeInterface".');
+            throw new InvalidArgumentException('The object must implement the "\DateTimeInterface".');
         }
 
         $format = isset($context[self::FORMAT_KEY]) ? $context[self::FORMAT_KEY] : $this->format;
@@ -61,6 +63,8 @@ public function supportsNormalization($data, $format = null)
 
     /**
      * {@inheritdoc}
+     *
+     * @throws UnexpectedValueException
      */
     public function denormalize($data, $class, $format = null, array $context = array())
     {
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/DateTimeNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/DateTimeNormalizerTest.php
@@ -52,8 +52,8 @@ public function testConstructorFormat()
     }
 
     /**
-     * @expectedException InvalidArgumentException
-     * @expectedExceptionMessage The object must implements the "\DateTimeInterface".
+     * @expectedException \Symfony\Component\Serializer\Exception\InvalidArgumentException
+     * @expectedExceptionMessage The object must implement the "\DateTimeInterface".
      */
     public function testInvalidDataThrowException()
     {
@@ -74,4 +74,12 @@ public function testDenormalize()
         $this->assertEquals(new \DateTimeImmutable('2016/01/01'), $this->normalizer->denormalize('2016-01-01T00:00:00+00:00', \DateTimeImmutable::class));
         $this->assertEquals(new \DateTime('2016/01/01'), $this->normalizer->denormalize('2016-01-01T00:00:00+00:00', \DateTime::class));
     }
+
+    /**
+     * @expectedException \Symfony\Component\Serializer\Exception\UnexpectedValueException
+     */
+    public function testInvalidDateThrowException()
+    {
+        $this->normalizer->denormalize('invalid date', \DateTimeInterface::class);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -52,8 +52,8 @@ public function testConstructorFormat()`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`/**`
`55`		`- * @expectedException InvalidArgumentException`
`56`		`- * @expectedExceptionMessage The object must implements the "\DateTimeInterface".`
	`55`	`+ * @expectedException \Symfony\Component\Serializer\Exception\InvalidArgumentException`
	`56`	`+ * @expectedExceptionMessage The object must implement the "\DateTimeInterface".`
`57`	`57`	`*/`
`58`	`58`	`public function testInvalidDataThrowException()`
`59`	`59`	`{`
`@@ -74,4 +74,12 @@ public function testDenormalize()`
`74`	`74`	`$this->assertEquals(new \DateTimeImmutable('2016/01/01'), $this->normalizer->denormalize('2016-01-01T00:00:00+00:00', \DateTimeImmutable::class));`
`75`	`75`	`$this->assertEquals(new \DateTime('2016/01/01'), $this->normalizer->denormalize('2016-01-01T00:00:00+00:00', \DateTime::class));`
`76`	`76`	`}`
	`77`	`+`
	`78`	`+ /**`
	`79`	`+ * @expectedException \Symfony\Component\Serializer\Exception\UnexpectedValueException`
	`80`	`+ */`
	`81`	`+ public function testInvalidDateThrowException()`
	`82`	`+ {`
	`83`	`+ $this->normalizer->denormalize('invalid date', \DateTimeInterface::class);`
	`84`	`+ }`
`77`	`85`	`}`