Apply suggestions from code review

jschaedl · web-flow · commit f06952dfebcd · 2020-10-05T23:00:36.000+02:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md b/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
@@ -13,7 +13,7 @@ CHANGELOG
  * added `framework.http_client.retry_failing` configuration tree
  * added `assertCheckboxChecked()` and `assertCheckboxNotChecked()` in `WebTestCase`
  * added `assertFormValue()` and `assertNoFormValue()` in `WebTestCase`
- * Added `--as-tree=3` option to `translation:update` command to dump messages as a tree-like structure. The given value defines the level where to switch to inline YAML
+ * Added "--as-tree=3" option to `translation:update` command to dump messages as a tree-like structure. The given value defines the level where to switch to inline YAML
 
 5.1.0
 -----
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationUpdateCommandTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Command/TranslationUpdateCommandTest.php
@@ -35,7 +35,7 @@ public function testDumpMessagesAndClean()
     public function testDumpMessagesAsTreeAndClean()
     {
         $tester = $this->createCommandTester(['messages' => ['foo' => 'foo']]);
-        $tester->execute(['command' => 'translation:update', 'locale' => 'en', 'bundle' => 'foo', '--dump-messages' => true, '--clean' => true, '--as-tree' => true]);
+        $tester->execute(['command' => 'translation:update', 'locale' => 'en', 'bundle' => 'foo', '--dump-messages' => true, '--clean' => true, '--as-tree' => 1]);
         $this->assertMatchesRegularExpression('/foo/', $tester->getDisplay());
         $this->assertMatchesRegularExpression('/1 message was successfully extracted/', $tester->getDisplay());
     }

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public function testDumpMessagesAndClean()`
`35`	`35`	`public function testDumpMessagesAsTreeAndClean()`
`36`	`36`	`{`
`37`	`37`	`$tester = $this->createCommandTester(['messages' => ['foo' => 'foo']]);`
`38`		`- $tester->execute(['command' => 'translation:update', 'locale' => 'en', 'bundle' => 'foo', '--dump-messages' => true, '--clean' => true, '--as-tree' => true]);`
	`38`	`+ $tester->execute(['command' => 'translation:update', 'locale' => 'en', 'bundle' => 'foo', '--dump-messages' => true, '--clean' => true, '--as-tree' => 1]);`
`39`	`39`	`$this->assertMatchesRegularExpression('/foo/', $tester->getDisplay());`
`40`	`40`	`$this->assertMatchesRegularExpression('/1 message was successfully extracted/', $tester->getDisplay());`
`41`	`41`	`}`