minor #51175 CI: Disable Psalm's findUnusedBaselineEntry feature (derrabus)

derrabus · derrabus · commit efff124ffedd · 2023-07-31T09:24:38.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- CI: Disable Psalm's `findUnusedBaselineEntry` feature | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Psalm has introduced a feature for detecting unused entries in the error baseline. This is useful for a baseline that is maintained along with the code because it tells the developer when the baseline starts to smell and needs to be regenerated. However, we use the baseline differently: We generate the baseline on the fly in order to check if a PR introduces new errors. Failing on baseline entries that can be purged is not what we want in that case because a contributor cannot fix those errors. Example for a Psalm run that failed because of unused baseline entries: https://github.com/symfony/symfony/actions/runs/5706412328/job/15462071408 Commits ------- 9ffbb53 CI: Disable Psalm's findUnusedBaselineEntry feature
diff --git a/psalm.xml b/psalm.xml
@@ -7,6 +7,7 @@
     xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
     cacheDirectory="./.github/psalm/cache/"
     errorBaseline=".github/psalm/psalm.baseline.xml"
+    findUnusedBaselineEntry="false"
 >
     <projectFiles>
         <directory name="src" />

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`	`xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"`
`8`	`8`	`cacheDirectory="./.github/psalm/cache/"`
`9`	`9`	`errorBaseline=".github/psalm/psalm.baseline.xml"`
	`10`	`+ findUnusedBaselineEntry="false"`
`10`	`11`	`>`
`11`	`12`	`<projectFiles>`
`12`	`13`	`<directory name="src" />`