bug #38950 [Process] Dont test TTY if there is no TTY support (Nyholm)

nicolas-grekas · nicolas-grekas · commit ed217a143579 · 2020-11-02T16:10:23.000+01:00
This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Process] Dont test TTY if there is no TTY support | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #38946 | License | MIT | Doc PR | Commits ------- e918e5a [Process] Dont test TTY if there is no TTY support
diff --git a/src/Symfony/Component/Process/Tests/ProcessTest.php b/src/Symfony/Component/Process/Tests/ProcessTest.php
@@ -476,6 +476,10 @@ public function testTTYCommand()
             $this->markTestSkipped('Windows does not have /dev/tty support');
         }
 
+        if (!Process::isTtySupported()) {
+            $this->markTestSkipped('There is no TTY support');
+        }
+
         $process = $this->getProcess('echo "foo" >> /dev/null && '.$this->getProcessForCode('usleep(100000);')->getCommandLine());
         $process->setTty(true);
         $process->start();
@@ -491,6 +495,10 @@ public function testTTYCommandExitCode()
             $this->markTestSkipped('Windows does have /dev/tty support');
         }
 
+        if (!Process::isTtySupported()) {
+            $this->markTestSkipped('There is no TTY support');
+        }
+
         $process = $this->getProcess('echo "foo" >> /dev/null');
         $process->setTty(true);
         $process->run();
@@ -1433,16 +1441,7 @@ public function testRawCommandLine()
         $p = Process::fromShellCommandline(sprintf('"%s" -r %s "a" "" "b"', self::$phpBin, escapeshellarg('print_r($argv);')));
         $p->run();
 
-        $expected = <<<EOTXT
-Array
-(
-    [0] => -
-    [1] => a
-    [2] => 
-    [3] => b
-)
-
-EOTXT;
+        $expected = "Array\n(\n    [0] => -\n    [1] => a\n    [2] => \n    [3] => b\n)\n";
         $this->assertSame($expected, str_replace('Standard input code', '-', $p->getOutput()));
     }
 
