fix(review): Nicolas Grekas

darkweak · darkweak · commit ec2bcc604b9c · 2025-11-20T07:35:16.000+01:00
diff --git a/src/Symfony/Bundle/WebProfilerBundle/CHANGELOG.md b/src/Symfony/Bundle/WebProfilerBundle/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+8.1
+---
+
+ * Add cURL copy paste button in the Request/Response tab
+
 8.0
 ---
 
@@ -12,7 +17,6 @@ CHANGELOG
  * Add support for the `QUERY` HTTP method in the profiler
  * Add support for Server-Sent Events / `EventSource` requests in the debug toolbar
  * Add support for displaying the application runner class
- * Add cURL copy paste button in the Request/Response tab
 
 7.3
 ---
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/request.html.twig b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/request.html.twig
@@ -239,10 +239,6 @@
                         <button class="btn btn-sm hidden" title="Copy as cURL" data-clipboard-text="{{ collector.curlCommand }}">Copy as cURL</button>
                         <pre class="break-long-words">{{ collector.curlCommand }}</pre>
                     </div>
-                {% else %}
-                    <div class="empty">
-                        <p>No content</p>
-                    </div>
                 {% endif %}
             </div>
         </div>
diff --git a/src/Symfony/Component/HttpKernel/DataCollector/RequestDataCollector.php b/src/Symfony/Component/HttpKernel/DataCollector/RequestDataCollector.php
@@ -503,34 +503,28 @@ private function computeCurlCommand(Request $request): ?string
     {
         $command = ['curl', '--compressed'];
 
-        // Build the full URL
         $scheme = $request->isSecure() ? 'https' : 'http';
         $host = $request->server->get('HTTP_HOST', $request->server->get('SERVER_NAME', 'localhost'));
         $url = $scheme.'://'.$host.$request->getRequestUri();
 
-        if (!empty($request->query->all())) {
+        if ($request->query->all()) {
             $url .= '?'.http_build_query($request->query->all());
         }
 
         // Add HTTP method
         $method = $request->getMethod();
-        switch ($method) {
-            case Request::METHOD_HEAD:
-                $command[] = '--head';
-                break;
-            case Request::METHOD_GET:
-                break;
-            default:
-                $command[] = \sprintf('--request %s', $method);
+
+        if ($method === Request::METHOD_HEAD) {
+            $command[] = '--head';
+        } elseif ($method !== Request::METHOD_GET) {
+            $command[] = '--request '.$method;
         }
 
         $command[] = \sprintf('--url %s', escapeshellarg($url));
 
         // Add headers
         foreach ($request->headers->all() as $name => $value) {
-            if (\is_array($value)) {
-                $value = implode(', ', $value);
-            }
+            $value = implode(', ', $value ?? []);
 
             // Skip certain headers
             if (\in_array(strtolower($name), ['host', 'cookie'])) {
@@ -541,7 +535,7 @@ private function computeCurlCommand(Request $request): ?string
         }
 
         // Add cookies
-        if (!empty($request->cookies->all())) {
+        if ($request->cookies->all()) {
             $cookies = [];
             foreach ($request->cookies->all() as $name => $value) {
                 $cookies[] = $name.'='.$value;
@@ -551,7 +545,7 @@ private function computeCurlCommand(Request $request): ?string
 
         // Add body data
         $content = $this->data['content'];
-        if (!empty($content) && \in_array($method, [Request::METHOD_POST, Request::METHOD_PUT, Request::METHOD_PATCH, Request::METHOD_DELETE])) {
+        if ($content && \in_array($method, [Request::METHOD_POST, Request::METHOD_PUT, Request::METHOD_PATCH, Request::METHOD_DELETE])) {
             $command[] = '--data-raw '.$this->escapePayload($content);
         }
 
