[Validator] - Bugfix for 18146 - EmailValidator cannot extract hostname if email contains multiple @ symbols

natechicago · natechicago · commit eabe394ea965 · 2016-03-16T21:58:22.000-05:00
diff --git a/src/Symfony/Component/Validator/Constraints/EmailValidator.php b/src/Symfony/Component/Validator/Constraints/EmailValidator.php
@@ -37,7 +37,7 @@ public function validate($value, Constraint $constraint)
         $valid = filter_var($value, FILTER_VALIDATE_EMAIL);
 
         if ($valid) {
-            $host = substr($value, strpos($value, '@') + 1);
+            $host = substr(strrchr($value, '@'), 1);
 
             // Check for host DNS resource records
             if ($valid && $constraint->checkMX) {
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/EmailValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/EmailValidatorTest.php
@@ -86,4 +86,19 @@ public function getInvalidEmails()
             array('example@localhost'),
         );
     }
+
+    public function testHostnameIsProperlyParsed()
+    {
+        DnsMock::withMockedHosts(array(
+            'baz.com' => array(array('type' => 'MX')),
+            '@bar"@baz.com' => array(array('type' => false)),
+        ));
+
+        $this->validator->validate(
+            '"foo@bar"@baz.com',
+            new Email(array('checkMX' => true))
+        );
+
+        $this->assertNoViolation();
+    }
 }
