Fix MoneyType: add missing step attribute when html5=true

Belhassen · Belhassen · commit e6b8bcb91f00 · 2025-12-04T13:51:29.000+01:00
diff --git a/src/Symfony/Component/Form/Extension/Core/Type/MoneyType.php b/src/Symfony/Component/Form/Extension/Core/Type/MoneyType.php
@@ -51,6 +51,12 @@ public function buildView(FormView $view, FormInterface $form, array $options)
 
         if ($options['html5']) {
             $view->vars['type'] = 'number';
+
+            if (!isset($view->vars['attr']['step'])) {
+                $view->vars['attr']['step'] = 'any';
+            }
+        } else {
+            $view->vars['attr']['inputmode'] = 0 === $options['scale'] ? 'numeric' : 'decimal';
         }
     }
 
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/MoneyTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/MoneyTypeTest.php
@@ -123,4 +123,44 @@ public function testHtml5EnablesSpecificFormatting()
         $this->assertSame('12345.60', $form->createView()->vars['value']);
         $this->assertSame('number', $form->createView()->vars['type']);
     }
+
+    public function testHtml5AddsStepAttributeIfNotSet()
+    {
+        $form = $this->factory->create(static::TESTED_TYPE, null, [
+            'html5' => true,
+        ]);
+        $view = $form->createView();
+        $this->assertSame('any', $view->vars['attr']['step']);
+
+        $form = $this->factory->create(static::TESTED_TYPE, null, [
+            'html5' => false,
+            'scale' => 2,
+        ]);
+        $view = $form->createView();
+        $this->assertSame('decimal', $view->vars['attr']['inputmode']);
+
+        $form = $this->factory->create(static::TESTED_TYPE, null, [
+            'html5' => false,
+            'scale' => 0,
+        ]);
+        $view = $form->createView();
+        $this->assertSame('numeric', $view->vars['attr']['inputmode']);
+    }
+
+    public function testHtml5DoesNotOverrideUserProvidedStep()
+    {
+        $form = $this->factory->create(static::TESTED_TYPE, null, [
+            'html5' => true,
+            'attr' => ['step' => '0.01'],
+        ]);
+        $view = $form->createView();
+        $this->assertSame('0.01', $view->vars['attr']['step']);
+
+        $form = $this->factory->create(static::TESTED_TYPE, null, [
+            'html5' => false,
+            'scale' => 2,
+        ]);
+        $view = $form->createView();
+        $this->assertSame('decimal', $view->vars['attr']['inputmode']);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,12 @@ public function buildView(FormView $view, FormInterface $form, array $options)`
`51`	`51`
`52`	`52`	`if ($options['html5']) {`
`53`	`53`	`$view->vars['type'] = 'number';`
	`54`	`+`
	`55`	`+ if (!isset($view->vars['attr']['step'])) {`
	`56`	`+ $view->vars['attr']['step'] = 'any';`
	`57`	`+ }`
	`58`	`+ } else {`
	`59`	`+ $view->vars['attr']['inputmode'] = 0 === $options['scale'] ? 'numeric' : 'decimal';`
`54`	`60`	`}`
`55`	`61`	`}`
`56`	`62`