bug #36789 Change priority of KernelEvents::RESPONSE subscriber (marcw)

fabpot · fabpot · commit e5c82c566efc · 2020-05-14T11:30:03.000+02:00
This PR was squashed before being merged into the 4.4 branch. Discussion ---------- Change priority of KernelEvents::RESPONSE subscriber | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT This PR changes the priority of the `KernelEvents::RESPONSE` subscriber of the `ProfilerListener` so that it is the penultimate to be executed (just before `StreamedResponseListener`). The reason is that other listeners that were executed after this one CAN change the response (such as `SessionListener` for example). This creates a headache when debugging, with a discrepancy between what is shown in a curl command, and by the Symfony profiler. Commits ------- 6ed624a Change priority of KernelEvents::RESPONSE subscriber
diff --git a/src/Symfony/Component/HttpKernel/EventListener/ProfilerListener.php b/src/Symfony/Component/HttpKernel/EventListener/ProfilerListener.php
@@ -119,7 +119,7 @@ public function onKernelTerminate(PostResponseEvent $event)
     public static function getSubscribedEvents()
     {
         return [
-            KernelEvents::RESPONSE => ['onKernelResponse', -100],
+            KernelEvents::RESPONSE => ['onKernelResponse', -1012],
             KernelEvents::EXCEPTION => ['onKernelException', 0],
             KernelEvents::TERMINATE => ['onKernelTerminate', -1024],
         ];

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ public function onKernelTerminate(PostResponseEvent $event)`
`119`	`119`	`public static function getSubscribedEvents()`
`120`	`120`	`{`
`121`	`121`	`return [`
`122`		`- KernelEvents::RESPONSE => ['onKernelResponse', -100],`
	`122`	`+ KernelEvents::RESPONSE => ['onKernelResponse', -1012],`
`123`	`123`	`KernelEvents::EXCEPTION => ['onKernelException', 0],`
`124`	`124`	`KernelEvents::TERMINATE => ['onKernelTerminate', -1024],`
`125`	`125`	`];`