bug #49186 [Serializer] Improve exception message in UnwrappingDenormalizer (andersonamuller)

fabpot · fabpot · commit e4bd5934d8da · 2024-05-17T11:01:24.000+02:00
This PR was submitted for the 7.1 branch but it was squashed and merged into the 6.4 branch instead. Discussion ---------- [Serializer] Improve exception message in UnwrappingDenormalizer | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - The current code expects the path to be replaced in the message, but probably it was forgotten. Commits ------- 3c96bfb [Serializer] Improve exception message in UnwrappingDenormalizer
diff --git a/src/Symfony/Component/Serializer/Context/Normalizer/UnwrappingDenormalizerContextBuilder.php b/src/Symfony/Component/Serializer/Context/Normalizer/UnwrappingDenormalizerContextBuilder.php
@@ -45,7 +45,7 @@ public function withUnwrapPath(?string $unwrapPath): static
         try {
             new PropertyPath($unwrapPath);
         } catch (InvalidPropertyPathException $e) {
-            throw new InvalidArgumentException('The "%s" property path is not valid.', previous: $e);
+            throw new InvalidArgumentException(sprintf('The "%s" property path is not valid.', $unwrapPath), previous: $e);
         }
 
         return $this->with(UnwrappingDenormalizer::UNWRAP_PATH, $unwrapPath);

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public function withUnwrapPath(?string $unwrapPath): static`
`45`	`45`	`try {`
`46`	`46`	`new PropertyPath($unwrapPath);`
`47`	`47`	`} catch (InvalidPropertyPathException $e) {`
`48`		`- throw new InvalidArgumentException('The "%s" property path is not valid.', previous: $e);`
	`48`	`+ throw new InvalidArgumentException(sprintf('The "%s" property path is not valid.', $unwrapPath), previous: $e);`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`return $this->with(UnwrappingDenormalizer::UNWRAP_PATH, $unwrapPath);`